----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33169/#review80025 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 14, 2015, 2:52 після полудня, Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33169/ > ----------------------------------------------------------- > > (Updated Квітень 14, 2015, 2:52 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-10467 > https://issues.apache.org/jira/browse/AMBARI-10467 > > > Repository: ambari > > > Description > ------- > > upgradeHelper use well old realization of curl via shell execute. And to > handle response errors use some kind of validation of response. For new > releases of Ambari response content could be changed from time to time. We > need to add some "soft" validation without generation error and just warn > user about unexpected response. > > > Diffs > ----- > > ambari-server/src/main/python/upgradeHelper.py 95d663a > ambari-server/src/test/python/TestUpgradeHelper.py 09dc360 > > Diff: https://reviews.apache.org/r/33169/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 263 tests in 6.244s > > OK > ---------------------------------------------------------------------- > Total run:673 > Total errors:0 > Total failures:0 > OK > > Process finished with exit code 0 > > > Thanks, > > Dmitro Lisnichenko > >
