[
https://issues.apache.org/jira/browse/AMBARI-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494753#comment-14494753
]
Hudson commented on AMBARI-10456:
---------------------------------
SUCCESS: Integrated in Ambari-trunk-Commit #2308 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/2308/])
AMBARI-10456 - Ambari Server Deadlock When Mapping Hosts (jonathanhurley)
(jhurley:
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=f11e2f0630f922cf7102fe4291d5c80230b4cb8c)
*
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AmbariEventPublisher.java
* ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/utils/EventBusSynchronizer.java
*
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
*
ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java
*
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
*
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
> Ambari Server Deadlock When Mapping Hosts
> -----------------------------------------
>
> Key: AMBARI-10456
> URL: https://issues.apache.org/jira/browse/AMBARI-10456
> Project: Ambari
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Jonathan Hurley
> Assignee: Jonathan Hurley
> Priority: Critical
> Fix For: 2.1.0
>
> Attachments: AMBARI-10456.patch, dump.txt
>
>
> When mapping hosts concurrently with reading information from a cluster,
> there was a deadlock between the building the cluster health report and
> mapping the new hosts.
> A few changes to note here:
> - ClustersImpl uses concurrent maps; there's really no need to keep the
> internal lock. I removed it in several places where the cluster is guaranteed
> to be available (such as when using the ID to retrieve the cluster). The
> concurrent maps guard against concurrent modifications.
> - The Ambari Event Publisher was actually synchronous. This not only caused
> bottlenecks, but also contributed to a secondary deadlock detected while
> fixing the original issue. It was changed into a single-threaded asynchronous
> bus. Consumers of this bus should never rely on it to perform its actions in
> order to perform their own logic, so changing the behavior seemed correct
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
