> On April 17, 2015, 4:14 p.m., Artem Baranchuk wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 38 > > <https://reviews.apache.org/r/33314/diff/1/?file=933837#file933837line38> > > > > Should we realy use clustered index here? > > The same for the other tables
Primary keys are generally supposed to be clustered, for the sake of speed. Non-lustered means the physical records are spread al across the table pages, which slows down the searches. There is no other clustered key on those tables, so the opportunity is there to create clustered primary keys. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33314/#review80467 ----------------------------------------------------------- On April 17, 2015, 3:59 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33314/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 3:59 p.m.) > > > Review request for Ambari, Artem Baranchuk, Jonathan Hurley, and Jayush > Luniya. > > > Bugs: AMBARI-10569 > https://issues.apache.org/jira/browse/AMBARI-10569 > > > Repository: ambari > > > Description > ------- > > Removed the syntax error artifacts. Added the missing tables. Added the > missing records to the sequence table. > > > Diffs > ----- > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > e38e2c5bfe5715128d7993b2ef6c3518d80754dc > > Diff: https://reviews.apache.org/r/33314/diff/ > > > Testing > ------- > > mvn clean install > deployment -> cluster setup -> task generation ok > > > Thanks, > > Florian Barca > >
