> On April 15, 2015, 6:19 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, > > line 248 > > <https://reviews.apache.org/r/33227/diff/1/?file=930747#file930747line248> > > > > Why don't we branch HBASE into a new version that is used for HDP 2.3? > > Perhaps sync up with Nick Dimiduk who is also refactoring HBASE and needs > > to branch it anyways because he's adding a component in HDP 2.3. > > The practice of checking for "is 2.x or higher" inside HDP 2.2 was a > > hack that we should not perpetuate. > > nick dimiduk wrote: > For reference, that AMABRI-9993, https://reviews.apache.org/r/33064/ > > Gautam Borad wrote: > @afernandez - We will move our changes for hbase in params_linux.py to > version 1.1.0.2.3. > However,do we ned to remove the condition of checking HDP version > 2.3 > also from there? > Our objective is that, these properties should get included only in HDP > 2.3 stacks.
For changes that are really HDP 2.3 specific, we should branch the component into HDP 2.3 stack instead of common services. However, your changes seem small enough that we can assume that HBASE 1.1.0.2.3 in common services will be for the HDP 2.3 stack, so we can start cleaning up the old logic of checking stack versions. If you want, you can still add a comment saying that it was introduced in HDP 2.3 - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33227/#review80233 ----------------------------------------------------------- On April 16, 2015, 2:31 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33227/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 2:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit > Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-10503 > https://issues.apache.org/jira/browse/AMBARI-10503 > > > Repository: ambari > > > Description > ------- > > Update Ambari Stacks to allow Ranger to support Solr DB for maintaining audit > logs. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/params_linux.py > abde3f2 > > ambari-server/src/main/resources/common-services/HBASE/1.1.0.2.3/package/scripts/setup_ranger_hbase.py > 7626de8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > 2a13337 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py > 9413d8e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > e5f9679 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py > 54de4a6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py > b3baf32 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py > c069fc5 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ac2bc0a > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > c1f365c > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > abc51d5 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py > a3cc587 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/33227/diff/ > > > Testing > ------- > > Tested with an ambari instance running ranger and a solr server running on > one of the node. > Checked the audit logs and they were getting generated for the plugins. ( > tested hdfs/hive/hbase/knox ) > > > Thanks, > > Gautam Borad > >
