----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33223/#review80518 -----------------------------------------------------------
Ship it! ambari-server/src/main/python/ambari_server/serverSetup.py <https://reviews.apache.org/r/33223/#comment130483> No need for the else statement. - Alejandro Fernandez On April 17, 2015, 6:05 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33223/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 6:05 p.m.) > > > Review request for Ambari, Artem Baranchuk, Alejandro Fernandez, Eugene > Chekanskiy, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-10491 > https://issues.apache.org/jira/browse/AMBARI-10491 > > > Repository: ambari > > > Description > ------- > > +Fixed service username handling at registration. > +Fixed service registration workflow. > +Updated unit tests. > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/os_windows.py > edbcc7be229a65b8b9d23b33eaecd3faefb346cb > ambari-server/src/main/python/ambari-server.py > f1f005d84cc9c77b870e6e3c75f673d773734c44 > ambari-server/src/main/python/ambari_server/serverConfiguration.py > c13202ccce19fd33c4f744b529b488de584a6df1 > ambari-server/src/main/python/ambari_server/serverSetup.py > ddb44fd02bb403d3db3d0844701a103081875bae > ambari-server/src/main/python/ambari_windows_service.py > 8e86163a05cf9655b0cf79cd4cd1124dddc2b295 > ambari-server/src/test/python/TestAmbariServer.py > 17e8aea143ddcae95509f1a87b72ea61718675aa > > Diff: https://reviews.apache.org/r/33223/diff/ > > > Testing > ------- > > mvn clean test on Mac > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 6.433 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.077 > s] > [INFO] Ambari Web ......................................... SUCCESS [ 34.249 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 2.596 > s] > [INFO] Ambari Admin View .................................. SUCCESS [ 11.574 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 1.832 > s] > [INFO] Ambari Server ...................................... SUCCESS [02:03 > min] > [INFO] Ambari Agent ....................................... SUCCESS [ 16.817 > s] > [INFO] Ambari Client ...................................... SUCCESS [ 0.055 > s] > [INFO] Ambari Python Client ............................... SUCCESS [ 1.721 > s] > [INFO] Ambari Groovy Client ............................... SUCCESS [ 9.779 > s] > [INFO] Ambari Shell ....................................... SUCCESS [ 0.050 > s] > [INFO] Ambari Python Shell ................................ SUCCESS [ 0.846 > s] > [INFO] Ambari Groovy Shell ................................ SUCCESS [ 7.643 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > mvn clean install -> deployment in a Windows domain cluster -> service starts > ok, logon successful, cluster setup wizard started ok > > > Thanks, > > Florian Barca > >
