----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33264/#review80544 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py <https://reviews.apache.org/r/33264/#comment130551> Typically most of the services create a pid file and that pid file is used to check if the process is alive. Can we have similar implementation? Also, if you do so we should have pid_dir to be a configurable property Ex: def status(self, env): import status_params env.set_params(status_params) check_process_status(status_params.knox_pid_file) knox-env.xml <property> <name>knox_pid_dir</name> <value>/var/run/knox</value> <description>Knox PID dir.</description> </property> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py <https://reviews.apache.org/r/33264/#comment130552> Might as well move this logic to kms_service. kms_service(action = "status") - Jayush Luniya On April 16, 2015, 3:10 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33264/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 3:10 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit > Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-10523 > https://issues.apache.org/jira/browse/AMBARI-10523 > > > Repository: ambari > > > Description > ------- > > Ranger KMS should be available as a service to be installed/managed from > Ambari. > User will be able to add a new service "Ranger KMS" and there will be one > Server component in the service. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-acls.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > ead3dd4 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/33264/diff/ > > > Testing > ------- > > Tested adding the Ranger KMS on an CentOS6 instance. > > > Thanks, > > Gautam Borad > >
