[ 
https://issues.apache.org/jira/browse/AMBARI-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508748#comment-14508748
 ] 

Hadoop QA commented on AMBARI-10683:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12727570/AMBARI-10683.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/2477//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/2477//console

This message is automatically generated.

> HDFS Review - Need theme changes for configs
> --------------------------------------------
>
>                 Key: AMBARI-10683
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10683
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.1.0
>            Reporter: Andrii Babiichuk
>            Assignee: Andrii Babiichuk
>            Priority: Critical
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10683.patch
>
>
> * Below configs should be removed from HDFS theme - they should only show up 
> in advanced tab. Also we need to verify that the recommended values are set 
> in the advanced tab.
> ** namenode_opt_newsize (hadoop-env.sh)
> ** namenode_opt_maxnewsize (hadoop-env.sh)
> ** namenode_opt_permsize (hadoop-env.sh)
> ** namenode_opt_maxpermsize (hadoop-env.sh)
> * We should have only 2 sections : {{NameNode}} and {{DataNode}}.
> ** {{NameNode}} should have 4 configs in below order vertically
> *** NameNode Directories
> *** NameNode Java heap size
> *** NameNode Server threads
> *** Minimum replicated blocks %ge
> ** {{DataNode}} should have 4 configs in below order vertically
> *** DataNode directories
> *** DataNode failed volume tolerance
> *** DataNode Java heap size
> *** DataNode max data transfer threads
> * {{dfs.datanode.failed.volumes.tolerated}} will be marked as {{depends_on}} 
> {{dfs.datanode.data.dir}}. When {{dfs.datanode.data.dir}} is changed, a call 
> to /recommendations should be made and new values applied to configs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to