> On April 23, 2015, 1:49 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 751 > > <https://reviews.apache.org/r/33461/diff/1/?file=940134#file940134line751> > > > > comment is for oozie but should be for Hive
Fixed in version 2 of the patch. > On April 23, 2015, 1:49 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 758 > > <https://reviews.apache.org/r/33461/diff/1/?file=940134#file940134line758> > > > > comment is for wrong service/component Fixed in version 2 of the patch. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33461/#review81310 ----------------------------------------------------------- On April 23, 2015, 1:13 a.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33461/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 1:13 a.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty. > > > Bugs: AMBARI-10489 > https://issues.apache.org/jira/browse/AMBARI-10489 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-10489 and AMBARI-10488. > > This patch includes some minor changes to the Blueprint configuration > processor > in order to support Blueprint deployments of HiveServer2, Hive MetaStore, > and WebHCat servers in a High Availability mode. > > This patch implements the following: > > - Updates the property updater implementations in the > BlueprintConfiguration processor in order to properly handle the cases > when more than one instance of HiveServer2, HiveMetaStore, or WebHCat > services are included in a Blueprint. When an HA scenario is > detected by the Blueprint processor, multiple instances of each of > these services is now supported. > > - Updates to the MultipleHostPropertyUpdater implementation, in > order to properly support the syntax of the "hive.metastore.uris" > property in hive-site, which can consist of a comma-separated > list of thrift:// URLs. > > - Modified the updater for "hive.metastore.uris" to refer to > the HIVE_METASTORE component, rather than HIVE_SERVER,since this > property should point to metastore servers. > > - Implements a new PropertyUpdater, TempletonHivePropertyUpdater, > in order to support the proper updating of the "hive.templeton.properties" > configuration value. > > - Updates the HDP 2.2 stack defintion for Hive, such that the > WEBHCAT_SERVER component has a new cardinality of "1+", so that > multiple instances of this component will be allowed in a > given cluster. > > - Implements new unit tests to verify these changes, and also updates > existing tests to accomodate for the changes. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > cec93bf > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml > fb9a596 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > aa9fa00 > > Diff: https://reviews.apache.org/r/33461/diff/ > > > Testing > ------- > > 1. Ran ambari-server unit tests (all passing) > 2. Verified that I can deploy a Hive HA cluster using a Blueprint to a 3-node > cluster. This cluster contains two of each of the following components > (HiveServer2, Hive MetaStore, WebHCat). > 3. Ran a simple, single-node cluster deployment with the Ambari UI, including > Hive, to make sure my minor stack change did not break anything in the UI > deployment. > > > Thanks, > > Robert Nettleton > >
