[ 
https://issues.apache.org/jira/browse/AMBARI-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509983#comment-14509983
 ] 

Hudson commented on AMBARI-10702:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #2421 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/2421/])
AMBARI-10702. Theme widgets should be merged from inherited theme 
(mpapirkovskyy via srimanth) (sgunturi: 
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d8bff0381cf307672652bb402292f91465783670)
* 
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/themes/theme.json
* ambari-server/src/test/resources/child-theme.json
* ambari-server/src/test/resources/parent-theme.json
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java
* 
ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/themes/theme.json
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java
* ambari-web/app/mappers/configs/themes_mapper.js
* 
ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
* 
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/themes/theme.json
* 
ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/themes/theme.json
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java
* 
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/themes-mapred/theme.json
* ambari-server/src/main/java/org/apache/ambari/server/state/ThemeInfo.java
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java
* ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java
* ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java
* 
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/themes/theme.json
* 
ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java


> Theme widgets should be merged from inherited theme
> ---------------------------------------------------
>
>                 Key: AMBARI-10702
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10702
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Myroslav Papirkovskyy
>            Assignee: Myroslav Papirkovskyy
>            Priority: Critical
>             Fix For: 2.1.0
>
>
> When implementing HDP-2.3 theme, the use case was to add just 2 more configs 
> to the enhanced-configs. When I created the default theme.json file, I had to 
> re-define all the widgets - even though the parent HDP-2.2 theme already had 
> most of them defined.
> Since it is a one-time operation, the {{widgets}} from the inherited parents 
> should be overridden by the child's widgets based on the "config" key.
> So HDP-2.3's theme.json ( 
> [https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/themes/theme.json]
>  ) should have only below 2 widget entries
> {code}
>       {
>         "config": "yarn-site/yarn.node-labels.enabled",
>         "widget": {
>           "type": "checkbox"
>         }
>       },
>       {
>         "config": "yarn-env/yarn_cgroups_enabled",
>         "widget": {
>           "type": "checkbox"
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to