> On April 24, 2015, 12:53 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml, > > line 146 > > <https://reviews.apache.org/r/33497/diff/1/?file=940673#file940673line146> > > > > This will introduce a regression. HBASE_REGIONSERVER_OPTS in HDP2.2 is > > set to the following and should be set to the same in HDP2.3 > > > > export HBASE_REGIONSERVER_OPTS="$HBASE_REGIONSERVER_OPTS > > -Xmn{{regionserver_xmn_size}} -XX:CMSInitiatingOccupancyFraction=70 > > -Xms{{regionserver_heapsize}} -Xmx{{regionserver_heapsize}} {% if > > hbase_max_direct_memory_size %} > > -XX:MaxDirectMemorySize={{hbase_max_direct_memory_size}}m {% endif %} > > -Djava.security.auth.login.config={{regionserver_jaas_config_file}}"
Ignore comment above. I was looking at wrong version > On April 24, 2015, 12:53 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-env.xml, > > line 147 > > <https://reviews.apache.org/r/33497/diff/1/?file=940673#file940673line147> > > > > This is a regression. Same explanation as above. > > > > Correct value should be. > > > > export HBASE_REGIONSERVER_OPTS="$HBASE_REGIONSERVER_OPTS > > -Xmn{{regionserver_xmn_size}} -XX:CMSInitiatingOccupancyFraction=70 > > -Xms{{regionserver_heapsize}} -Xmx{{regionserver_heapsize}} {% if > > hbase_max_direct_memory_size %} > > -XX:MaxDirectMemorySize={{hbase_max_direct_memory_size}}m {% endif %}" Ignore comment above. I was looking at wrong version. - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33497/#review81439 ----------------------------------------------------------- On April 24, 2015, 12:25 a.m., nick dimiduk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33497/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 12:25 a.m.) > > > Review request for Ambari and Jayush Luniya. > > > Bugs: AMBARI-10712 > https://issues.apache.org/jira/browse/AMBARI-10712 > > > Repository: ambari > > > Description > ------- > > per JIRA. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 311819a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-env.xml > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c54d2b0 > ambari-server/src/test/python/stacks/2.3/configs/hbase_secure.json 8580db6 > > Diff: https://reviews.apache.org/r/33497/diff/ > > > Testing > ------- > > > Thanks, > > nick dimiduk > >
