-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33517/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-10726
    https://issues.apache.org/jira/browse/AMBARI-10726


Repository: ambari


Description
-------

yarn.scheduler.maximum-allocation-vcores value is not being recommended in the 
/recommendations API. It should be the same as 
yarn.nodemanager.resource.cpu-vcores. I see the maximum, but even the value 
should be provided.
Current output:
            "yarn-site" : {
              "properties" : {
                "yarn.scheduler.minimum-allocation-mb" : "682",
                "yarn.scheduler.maximum-allocation-mb" : "2048",
                "yarn.nodemanager.resource.cpu-vcores" : "2",
                "yarn.nodemanager.resource.memory-mb" : "2048"
              },
              "property_attributes" : {
                "yarn.scheduler.minimum-allocation-vcores" : {
                  "maximum" : "2"
                },
                "yarn.scheduler.maximum-allocation-vcores" : {
                  "maximum" : "2"
                },
                "yarn.nodemanager.resource.memory-mb" : {
                  "maximum" : "2887"
                },
                "yarn.scheduler.minimum-allocation-mb" : {
                  "maximum" : "2048"
                },
                "yarn.nodemanager.resource.cpu-vcores" : {
                  "maximum" : "4"
                },
                "yarn.scheduler.maximum-allocation-mb" : {
                  "maximum" : "2048"
                }
              }


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
ba05ffa 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 96df408 

Diff: https://reviews.apache.org/r/33517/diff/


Testing
-------

----------------------------------------------------------------------
Ran 263 tests in 8.162s

OK
----------------------------------------------------------------------
Total run:714
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen

Reply via email to