-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33526/
-----------------------------------------------------------
(Updated April 24, 2015, 3:57 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Changes
-------
Updated to fix the issue that Nate pointed out and to provide some tests.
Bugs: AMBARI-10736
https://issues.apache.org/jira/browse/AMBARI-10736
Repository: ambari
Description
-------
Downgrade must determine, or be passed, the targeted downgrade stack. In the
event that the downgrade is moving to a version that is different than the
current desired (as determined by the Cluster desired stack version), Downgrade
must remove those configurations.
After which, the most current configs for the targeted downgrade version should
be re-set as the current for the cluster.
In addition, the ConfigureAction must be augmented to understand that when it
is being invoked by a downgrade, and is across stacks, that it may be no-opping
as it reverts
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
730fba5
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
35a1700
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
fbaec3e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
8a79d1f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigMappingEntity.java
fa48399
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java
1a31252
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
49e241f
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
855bb3f
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
6436e22
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
2558de8
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
e7a5185
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
fc86c7a
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
9c129e8
Diff: https://reviews.apache.org/r/33526/diff/
Testing (updated)
-------
Manually tested downgrade about 100 zillion times, monitoring the database.
mvn clean test
Thanks,
Jonathan Hurley
