----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33589/#review81701 -----------------------------------------------------------
Ship it! Other than characters flagged by the reviewer UI, this look good. However, I am not really familiar with views or Spring, so maybe someone other than me should have a look. ambari-views/examples/hello-spring-view/docs/index.md <https://reviews.apache.org/r/33589/#comment132127> The single quotes around _hello_ are being flagged by this UI for some reason... FYI. ambari-views/examples/hello-spring-view/docs/index.md <https://reviews.apache.org/r/33589/#comment132128> Whitespace at the end of these lines are being flagged. FYI... - Robert Levas On April 27, 2015, 1:57 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33589/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 1:57 p.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: AMBARI-10767 > https://issues.apache.org/jira/browse/AMBARI-10767 > > > Repository: ambari > > > Description > ------- > > Create a Spring web app deployed as a view. Show ... > > 1. use of different version of Spring from Ambari > 2. jsp > 3. obtain view context in controller > > > Diffs > ----- > > ambari-views/examples/hello-spring-view/docs/index.md PRE-CREATION > ambari-views/examples/hello-spring-view/pom.xml PRE-CREATION > > ambari-views/examples/hello-spring-view/src/main/java/org/apache/ambari/view/hello/HelloController.java > PRE-CREATION > ambari-views/examples/hello-spring-view/src/main/resources/view.xml > PRE-CREATION > > ambari-views/examples/hello-spring-view/src/main/webapp/WEB-INF/Hello-servlet.xml > PRE-CREATION > > ambari-views/examples/hello-spring-view/src/main/webapp/WEB-INF/jsp/hello.jsp > PRE-CREATION > ambari-views/examples/hello-spring-view/src/main/webapp/WEB-INF/web.xml > PRE-CREATION > ambari-views/examples/pom.xml adb76b1 > > Diff: https://reviews.apache.org/r/33589/diff/ > > > Testing > ------- > > Manual deploy and test Hello Spring view. > > All unit tests pass. > > > Thanks, > > Tom Beerbower > >
