----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33649/#review81907 -----------------------------------------------------------
Ship it! Ship It! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java <https://reviews.apache.org/r/33649/#comment132451> Why a specific change for accumulo-site? - Sumit Mohanty On April 29, 2015, 12:30 a.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33649/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 12:30 a.m.) > > > Review request for Ambari, Mahadev Konar and Robert Nettleton. > > > Bugs: AMBARI-10811 > https://issues.apache.org/jira/browse/AMBARI-10811 > > > Repository: ambari > > > Description > ------- > > When provisioning a cluster using a blueprint that contains HA components or > an existing MYSQL_SERVER or implicit MYSQL_SERVER (not explicitly specified > in blueprint but required by dependency) the cluster fails to deploy. > The request remains in the PENDING state and at 0% complete. > > Output like the following is logged to ambari-server.out: > TopologyManager.ConfigureClusterTask: Entering > Caught an error from Config Processor: java.lang.IllegalArgumentException: > Unable to determine required host groups for component. Component > 'MYSQL_SERVER' is not mapped to any host group or is mapped to multiple > groups. > > This is a regression as a result of > https://issues.apache.org/jira/browse/AMBARI-10750 > The problem was that the blueprint config processor was not dealing with > these topologies properly when trying to determine which host groups needed > to be resolved prior to updating configuration. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 95e9807 > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > 1bffbf2 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > 3e1b565 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 34b239b > > Diff: https://reviews.apache.org/r/33649/diff/ > > > Testing > ------- > > Functional Testing: > - Tested that the provided topologies don't result in the above error > > Unit Testing: > - added new test > - currently running entire unit test suite and will update review with > results prior to merging > - > On new laptop I didn't set the terminal buffer size so the Java test results > scrolled off. > Here is the output from the end of the tests: > > OK > ---------------------------------------------------------------------- > Total run:686 > Total errors:0 > Total failures:0 > > > Thanks, > > John Speidel > >
