----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33655/#review81976 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java <https://reviews.apache.org/r/33655/#comment132538> Won't this leave orphaned content in tables like clusterconfig and serviceconfig? I'm curious ... wouldn't it be better to run something before the upgrade catalogs that sets up the data in the way the entities need it? Converting all of this to SQL doesn't seem like the best move. - Jonathan Hurley On April 28, 2015, 9:51 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33655/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 9:51 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-10170 > https://issues.apache.org/jira/browse/AMBARI-10170 > > > Repository: ambari > > > Description > ------- > > The older upgrade catalogs cannot use any of Entity models that are related > to the hosts table because the host_name is no longer present (instead the > host_id). > For this reason, I changed the UpgradeCatalogs to use raw SQL. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java > ac8bb52 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java > 23ffad0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 4117a1c > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 804aa60 > > Diff: https://reviews.apache.org/r/33655/diff/ > > > Testing > ------- > > Created VMs with each of the following Ambari versions and tested these > upgrade paths. > 2.0.0 -> 2.1.0 (has known issues due to XML > properties) > 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks > table, this removed Nagios service, which was tested in UpgradeCatalog200) > 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 (has known issues due to the stacks > table, this updated the host_role_command table, which was tested in > UpgradeCatalog170) > 1.6.0 -> 1.6.1 -> 1.7.0 -> 2.0.0 -> 2.1.0 > > To get these work, I had to comment out certain functions that are known to > fail today. > > I ran local unit tests on > ambari-server/src/test/java/org/apache/ambari/server/upgrade and they passed. > > > Thanks, > > Alejandro Fernandez > >
