> On April 29, 2015, 11:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py,
> > line 21
> > <https://reviews.apache.org/r/33698/diff/1/?file=945754#file945754line21>
> >
> > Use named imports
I've spent about the last 3 hours trying to narrow down the imports. The
limited set appears to be:
from metadata import metadata
from resource_management import Execute, check_process_status, Script
However, I can no longer pass the unit tests:
Traceback (most recent call last):
File
"/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py",
line 107, in test_start_default
user = 'atlas',
File
"/Users/jmaron/dev/workspaces/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
line 233, in assertResourceCalled
self.assertEquals(name, resource.name)
AssertionError: 'source /etc/atlas/conf/metadata-env.sh ;
/usr/hdp/current/atlas-server/bin/metadata-start.sh --port 21000' != 'source
{params.conf_dir}/metadata-env.sh ; {params.metadata_start_script} --port
{params.metadata_port}'
If I change it back to 'from resource management import *' the unit tests once
again pass.
Do you happen to know the less than obvious import(s) I am missing? I am
checking against other service scripts, but most seem to be importinb '*'
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33698/#review82054
-----------------------------------------------------------
On April 29, 2015, 9:37 p.m., Jonathan Maron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33698/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 9:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty,
> and Sid Wagle.
>
>
> Bugs: https://issues.apache.org/jira/browse/AMBARI-10853
>
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This is the initial commit for a service definition for Apache Atlas. It
> provides the files necessary to install, configure, and start the Atlas
> Metadata Server. There will be follow on commits for supporting:
>
> 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has
> yet to be leveraged and tested but is in the package for completeness/place
> holder).
> 2) UI enhancements - configuration panels, quick links, metrics (an
> alerts.json is included for completeness but not tested)
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2
> PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json
> 93be128
> ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml
> PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py
> PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22
>
> Diff: https://reviews.apache.org/r/33698/diff/
>
>
> Testing
> -------
>
> Functional testing was performed using an Amabri installation on a local
> VM-based network. In addition, unit tests for configure, start, and stop
> have been written.
>
>
> Thanks,
>
> Jonathan Maron
>
>
