----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33743/#review82555 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On May 5, 2015, 1:34 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33743/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 1:34 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jaimin Jetly, Jonathan Hurley, > Nate Cole, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-10877 > https://issues.apache.org/jira/browse/AMBARI-10877 > > > Repository: ambari > > > Description > ------- > > Delete a host (even if request does not specify a cluster name), should > delete all references to it. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 45900e4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java > 34d0e3c > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > 7d3f4e4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostStateDAO.java > f939de3 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > de3b8cb > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java > db0817b > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostConfigMappingEntity.java > 915b05f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java > 061f436 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostStateEntity.java > 52ae322 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 3764dd1 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 9e63ff2 > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > 27f4800 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > ffe35af > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAOTest.java > 0dcc471 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java > 3d93e4d > ambari-web/app/messages.js 652c415 > ambari-web/app/templates/main/host/details/doDeleteHostPopup.hbs a149364 > > Diff: https://reviews.apache.org/r/33743/diff/ > > > Testing > ------- > > Deployed a cluster with 5 hosts, of which Host 1 and 2 had masters installed, > Host 3 only had clients, and Hosts 4 and 5 had no components at all. > 1. Created a config group for ZK with host 1 and 2, called Group 1 > 2. Created a config group for ZK with host 3 and 4, called Group 2 > 3. Created config override for Group 1 > 4. Ran commands to restart services on Host 2 and 3, thereby generating > stages and requests > 5. Stoped all components on host 2, then deleted them, then deleted the host > 6. Deleted host 3, 4, and 5 > > Local unit tests passed > > > Thanks, > > Alejandro Fernandez > >
