----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33917/#review82787 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java <https://reviews.apache.org/r/33917/#comment133602> Do we need any type of log messages or exceptions when the expected values (like t.fromKey) are null? Since we don't validate the XML with an XSD, it could be easy to mess up the upgrade pack and we wouldn't produce output why some properties didn't get transferred. - Jonathan Hurley On May 6, 2015, 6:26 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33917/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 6:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom > Beerbower. > > > Bugs: AMBARI-10981 > https://issues.apache.org/jira/browse/AMBARI-10981 > > > Repository: ambari > > > Description > ------- > > * Added config copy/move/delete capability to processing of the upgrade pack > * New tests for ConfigureAction to work with the new structures. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 99535c2 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > df9d7be > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > d3cb366 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TransferOperation.java > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 8dccf65 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > 391db55 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > 1701a33 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 088d15f > > Diff: https://reviews.apache.org/r/33917/diff/ > > > Testing > ------- > > Tests run: 2950, Failures: 0, Errors: 0, Skipped: 17 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 32:56.845s > [INFO] Finished at: Wed May 06 18:02:37 EDT 2015 > [INFO] Final Memory: 31M/751M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
