----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33698/#review83002 -----------------------------------------------------------
Ship it! ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json <https://reviews.apache.org/r/33698/#comment133880> This isn't hurting anything, but since there is only one component and it already references (and modifies) the `/spnego` identitiy, there is no need for the service-level declaration. If there were multiple components and at least one didn't have any modifications for the base identities, than the service-level declaration would be needed. ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py <https://reviews.apache.org/r/33698/#comment133881> This class should have a `security_status` method to report back to Ambari whether it is properly configured for Kerberos or not. See common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py:80 for example. ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py <https://reviews.apache.org/r/33698/#comment133882> get_kinit_path should be called with the user-declared search paths: ``` kinit_path_local = get_kinit_path(default('/configurations/kerberos-env/executable_search_paths', None)) ``` Is this even used? Actually it may be if `security_status` is implemented in the lifecycle script. - Robert Levas On May 1, 2015, 10:24 a.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33698/ > ----------------------------------------------------------- > > (Updated May 1, 2015, 10:24 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, > and Sid Wagle. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-10853 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853 > > > Repository: ambari > > > Description > ------- > > This is the initial commit for a service definition for Apache Atlas. It > provides the files necessary to install, configure, and start the Atlas > Metadata Server. There will be follow on commits for supporting: > > 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has > yet to be leveraged and tested but is in the package for completeness/place > holder). > 2) UI enhancements - configuration panels, quick links, metrics (an > alerts.json is included for completeness but not tested) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/files/log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json > 93be128 > ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22 > > Diff: https://reviews.apache.org/r/33698/diff/ > > > Testing > ------- > > Functional testing was performed using an Amabri installation on a local > VM-based network. In addition, unit tests for configure, start, and stop > have been written. > > > Thanks, > > Jonathan Maron > >
