----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33996/#review83069 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py <https://reviews.apache.org/r/33996/#comment133935> hdfs_principal_name is not declared in this patch. where is the variable decalred ? - Jaimin Jetly On May 8, 2015, 8:01 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33996/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 8:01 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-11034 > https://issues.apache.org/jira/browse/AMBARI-11034 > > > Repository: ambari > > > Description > ------- > > - > > > Diffs > ----- > > ambari-agent/pom.xml a08e81c > ambari-agent/src/test/python/resource_management/TestContentSources.py > d35ec9a > ambari-agent/src/test/python/resource_management/TestCopyFromLocal.py > 1ec1858 > > ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py > bb91159 > ambari-agent/src/test/python/resource_management/TestRepositoryResource.py > 6b94481 > ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py > a7eaae9 > ambari-common/src/main/python/resource_management/core/source.py 9d1fc76 > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > e06d246 > > ambari-common/src/main/python/resource_management/libraries/functions/version.py > 1de6bf8 > > ambari-common/src/main/python/resource_management/libraries/providers/__init__.py > 34b10a9 > > ambari-common/src/main/python/resource_management/libraries/providers/copy_from_local.py > bd9805c > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_directory.py > 9fa2de7 > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/resources/__init__.py > 596c2e2 > > ambari-common/src/main/python/resource_management/libraries/resources/copy_from_local.py > 42050a3 > > ambari-common/src/main/python/resource_management/libraries/resources/hdfs_directory.py > 7888cd8 > > ambari-common/src/main/python/resource_management/libraries/resources/hdfs_resource.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 9f8653b > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo.py > e974573 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py > 88d83d3 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > 5bb80de > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py > cd9f8f9 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 7e516b8 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > ed9098c > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 27ced1d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > 9a35a24 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 59ebb6c1 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py > a60ebad > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/fast-hdfs-resource.jar > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > a615c27 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > e36019e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py > ad5ef89 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py > 3feff67 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > d8d99d5 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py > dd319b0 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh > d16848d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > bfd4e74 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > d86de3d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > bd6f70e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py > 733ab0a > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py > 9b59f30 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/templates/templeton_smoke.pig.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py > 5e0096f > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/service_check.py > f46c41f > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/oozieSmoke2.sh > 32211c4 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/files/prepareOozieHdfsDirectories.sh > PRE-CREATION > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > 6adf2ac > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py > c3d9c78 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > 5875284 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py > d589452 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py > c4fb033 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > 9de30ed > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py > 0206415 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py > f430743 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py > 80d6bbc > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_service.py > 26a403d > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml > 5aadd99 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_linux.py > 5db3422 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py > 6786eba > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py > f4dceb5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py > a18ca72 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py > 6d17aca > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > ae736de > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py > 9d5fb97 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py > 81da809 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > 583e6e9 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > b56d15a > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py > ea8d9d4 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8b7846c > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 9975b36 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e7af32 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py d683198 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py > 3c098b6 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 5bedf5b > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 8e7f34f > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 670092d > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py > 7bbd0a9 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py > 3fa1c9c > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py > d0a71c0 > ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py > bcd5ad9 > ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py > df30085 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > efec6f7 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > 26fab63 > > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_service_check.py > 01073df > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 46e7cbc > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > f40beac > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 02b020b > ambari-server/src/test/python/stacks/2.0.6/configs/default.json c90d085 > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f000ef3 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > d4017f7 > ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py > cd6f693 > ambari-server/src/test/python/stacks/2.1/TEZ/test_service_check.py 50d99dd > ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py > dd3f4f2 > ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py > 60d7924 > ambari-server/src/test/python/stacks/2.2/configs/default.json c5a6ae7 > ambari-server/src/test/python/stacks/2.2/configs/secured.json 5bd8814 > > ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py > 0d943c4 > contrib/fast-hdfs-resource/dependency-reduced-pom.xml PRE-CREATION > contrib/fast-hdfs-resource/pom.xml PRE-CREATION > contrib/fast-hdfs-resource/resources/example.json PRE-CREATION > contrib/fast-hdfs-resource/resources/test_perfomance.sh PRE-CREATION > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Resource.java > PRE-CREATION > > contrib/fast-hdfs-resource/src/main/java/org/apache/ambari/fast_hdfs_resource/Runner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33996/diff/ > > > Testing > ------- > > tested HA + non-secure/secure - 2.3 stack > tested non-secure/secure - 2.2 stack > tested deploy - stack 2.0 > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
