----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34019/#review83259 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On May 11, 2015, 1:28 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34019/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 1:28 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan > Hurley, Nate Cole, Sumit Mohanty, Srimanth Gunturi, and Sid Wagle. > > > Bugs: AMBARI-11009 > https://issues.apache.org/jira/browse/AMBARI-11009 > > > Repository: ambari > > > Description > ------- > > 1. In HDP 2.3, when installing multiple nimbus servers, the service check > fails. To resolve this, modify the cmd as follows, > storm jar /tmp/wordCount.jar storm.starter.WordCountTopology WordCount{unique} > if nimbus.seeds is supported and in the storm configs. > 2. In RU from HDP 2.2 -> 2.3.0.0, Storm will not be rolling, so the upgrade > pack still needs instructions to deactivate and kill running topologies > before upgrading Storm, and to rebuild the topologies after. > In 2.3.0.0, Storm's defaults.yaml will have the property > storm.meta.serialization.delegate set to > backtype.storm.serialization.GzipThriftSerializationDelegate, so as long as > Ambari doesn't override the property, the RU from 2.3.0.0 to 2.3+ will be > rolling. So the upgrade pack from Dal to Dal will not need these manual > confirmations. > To test this out, deploy HDP 2.3.0.0, then perform and RU to HDP 2.3+, and > verify the topologies are still running > 3. Currently, the nimbus.seeds property is marked as final and cannot be > edited in the UI, so this needs to change to enable Nimbus HA > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 6c96d73 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py > 483c144 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py > aeda3b3 > > ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/STORM/package/scripts/yaml_config.py > 39261be > > ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml > 3ecc014 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml > 65549dd > ambari-server/src/test/python/stacks/2.3/STORM/test_service_check.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/storm_default.json > PRE-CREATION > ambari-web/app/data/HDP2/site_properties.js 2c50819 > > Diff: https://reviews.apache.org/r/34019/diff/ > > > Testing > ------- > > Created 3 CentOS 6 VMs, installed Ambari Server 2.1.0 at build 1457 > Installed HDP 2.3.0.0-1889 with Storm and ZK, and my patch > Storm service check passed > The nimbus.seeds property is not final > Attempted a Rolling Upgrade to HDP 2.3.0.0-1891 and the confirmation message > for Storm did not appear, as expected. > > Unit tests passed. > > ----------------------------------------------------------------------- > Total run:734 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
