----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34049/#review83270 -----------------------------------------------------------
Ship it! Looks good. - Tom Beerbower On May 11, 2015, 6:41 p.m., Sreenath Somarajapuram wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34049/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 6:41 p.m.) > > > Review request for Ambari, Erik Bergenholtz and Tom Beerbower. > > > Bugs: AMBARI-11042 > https://issues.apache.org/jira/browse/AMBARI-11042 > > > Repository: ambari > > > Description > ------- > > The view should support for auto creation and cluster association as per > BUG-33695 > The patch supports: > 1. Creating / Instantiation > 2. Configuration / Cluster association > 3. Protocol addition to URL (Adding http://) > > > Diffs > ----- > > > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ConfigurationService.java > PRE-CREATION > > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/PropertyService.java > PRE-CREATION > > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/SettingService.java > PRE-CREATION > contrib/views/tez/src/main/resources/ui/scripts/init-ambari-view.js 6f44211 > contrib/views/tez/src/main/resources/view.xml 33a1c40 > > Diff: https://reviews.apache.org/r/34049/diff/ > > > Testing > ------- > > - Tested on cluster, and non-cluster environment. > - Checked auto instantiation. > - Validated confuguration on manual instance. > > - Configuration change on auto deployed instance is yet to be validated. > > > Thanks, > > Sreenath Somarajapuram > >
