----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34054/#review83287 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On May 11, 2015, 7:50 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34054/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 7:50 p.m.) > > > Review request for Ambari, Robert Nettleton and Sumit Mohanty. > > > Bugs: AMBARI-11038 > https://issues.apache.org/jira/browse/AMBARI-11038 > > > Repository: ambari > > > Description > ------- > > When provisioning via a blueprint, if all hosts required for config topology > resolution are registed prior to submitting the cluster creation template, > the host install and start tasks could execute prior to the configuration > task which resulted in invalid configurations on these hosts. > > The solution is to submit the configuration task prior to processing the > request in the topology manager and also required a change to the > configuration processing task where it determines when the necessary hosts > are known to do cluster topology resolution. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java > a8c2ff3 > > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java > 087ad4c > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > 864655d > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 53abd1c > > Diff: https://reviews.apache.org/r/34054/diff/ > > > Testing > ------- > > Functional Testing: > - provisioned a cluster when: > -- all agents were registered prior to the cluster creation request > submission > -- some agents were registered prior to the cluster creation request > submission > -- no agents were registered prior to the cluster creation request > submission > -- no agents were registered prior to the cluster creation request > submission but all fqdn are specified in request > > Unit Tests: > All tests pass and current test updated > > Tests run: 2964, Failures: 0, Errors: 0, Skipped: 20 > > > Thanks, > > John Speidel > >
