> On May 13, 2015, 12:53 p.m., Jonathan Hurley wrote: > > I don't see how these changes would fix a NullPointerException from > > StackEntity.
there's no null pointer exceptions and initial issue were fixed in other issue - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34163/#review83595 ----------------------------------------------------------- On May 13, 2015, 12:37 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34163/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 12:37 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-11103 > https://issues.apache.org/jira/browse/AMBARI-11103 > > > Repository: ambari > > > Description > ------- > > Upgrade Ambari 2.0.0 to 2.1.0 and it fails while executing data > transformations. > See attached database. > > > ClusterImpl.java:265 > {code} > desiredStackVersion = new StackId(clusterEntity.getDesiredStack()); > {code} > > StackId.java:50 > {code} > public StackId(StackEntity stackEntity) { > this(stackEntity.getStackName(), stackEntity.getStackVersion()); > } > {code} > > {code} > 24 Apr 2015 01:35:58,493 ERROR [main] SchemaUpgradeHelper:231 - Upgrade > failed. > java.lang.NullPointerException > at org.apache.ambari.server.state.StackId.<init>(StackId.java:50) > at > org.apache.ambari.server.state.cluster.ClusterImpl.<init>(ClusterImpl.java:265) > at > org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$9616e406.<init>(<generated>) > at > org.apache.ambari.server.state.cluster.ClusterImpl$$EnhancerByGuice$$9616e406$$FastClassByGuice$$89b410a5.newInstance(<generated>) > at > com.google.inject.internal.cglib.reflect.$FastConstructor.newInstance(FastConstructor.java:40) > at > com.google.inject.internal.ProxyFactory$ProxyConstructor.newInstance(ProxyFactory.java:260) > at > com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:85) > at > com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:254) > at > com.google.inject.internal.InjectorImpl$4$1.call(InjectorImpl.java:978) > at > com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1024) > at > com.google.inject.internal.InjectorImpl$4.get(InjectorImpl.java:974) > at > com.google.inject.assistedinject.FactoryProvider2.invoke(FactoryProvider2.java:632) > at com.sun.proxy.$Proxy10.create(Unknown Source) > at > org.apache.ambari.server.state.cluster.ClustersImpl.loadClustersAndHosts(ClustersImpl.java:168) > at > org.apache.ambari.server.state.cluster.ClustersImpl.checkLoaded(ClustersImpl.java:157) > at > org.apache.ambari.server.state.cluster.ClustersImpl.getClusters(ClustersImpl.java:568) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.addNewConfigurationsFromXml(AbstractUpgradeCatalog.java:186) > at > org.apache.ambari.server.upgrade.UpgradeCatalog210.executeDMLUpdates(UpgradeCatalog210.java:692) > at > org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeData(AbstractUpgradeCatalog.java:381) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:229) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:297) > 24 Apr 2015 01:35:58,497 ERROR [main] SchemaUpgradeHelper:308 - Exception > occurred during upgrade, failed > org.apache.ambari.server.AmbariException > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeDMLUpdates(SchemaUpgradeHelper.java:232) > at > org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:297) > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > d2b9610 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > c27849b > > Diff: https://reviews.apache.org/r/34163/diff/ > > > Testing > ------- > > Running org.apache.ambari.server.upgrade.UpgradeCatalog210Test > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.059 sec > > > Thanks, > > Dmitro Lisnichenko > >
