----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34123/#review83614 -----------------------------------------------------------
Ship it! Ship It! - John Speidel On May 13, 2015, 3:09 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34123/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 3:09 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Robert Levas. > > > Bugs: AMBARI-11087 > https://issues.apache.org/jira/browse/AMBARI-11087 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-11087. > > The BlueprintConfigurationProcessor has been modified to account for a new > Storm property, "nimbus.seeds", that must be set to a comma-separated list of > Nimbus Server hosts. This property is used by Storm clients to discover the > list of HA Nimbus servers available in the cluster. This property uses Yaml, > and so the default Yaml PropertyUpdater in the > BlueprintConfigurationProcessor has been modified to account for different > Yaml Flow styles. This patch also registers this property updater to > "nimbus.seeds" for processing during cluster creation. > > This patch also adds unit tests to verify this change, and updates existing > unit tests to accomodate this change as well. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 7938cc1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > e7b0c64 > > Diff: https://reviews.apache.org/r/34123/diff/ > > > Testing > ------- > > 1. Manual testing done with a 3-node cluster. Current problems with Storm > keep the initial Storm services from starting properly, but I was able to > verify that the "nimbus.seeds" configuration property is set correctly at the > completion of the cluster startup. With a local patch to Storm itself, I can > get all the Storm services to start properly. > 2. Ran the ambari-server unit tests, ran into 1 un-related failure: > "Failed tests: > testPopulateResourcesForRegexpMetrics(org.apache.ambari.server.controller.metrics.timeline.AMSPropertyProviderTest): > expected:<...rics.%25.AvailableMB[]&appId=RESOURCEMANAG...> but > was:<...rics.%25.AvailableMB[%2Cyarn.QueueMetrics.%25.AvailableMB._min%2Cyarn.QueueMetrics.%25.AvailableMB._max%2Cyarn.QueueMetrics.%25.AvailableMB._avg%2Cyarn.QueueMetrics.%25.AvailableMB._sum]&appId=RESOURCEMANAG…>". > This unit test failure will be fixed in a separate patch by the Metrics > team. > > > Thanks, > > Robert Nettleton > >
