-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34127/
-----------------------------------------------------------

(Updated May 13, 2015, 12:55 p.m.)


Review request for Ambari, Emil Anca and Robert Nettleton.


Changes
-------

Fixed test case issue.


Bugs: AMBARI-11085
    https://issues.apache.org/jira/browse/AMBARI-11085


Repository: ambari


Description
-------

There are some naming consistency issues and there are missing entries in the 
CSV related to AMS.

#Naming inconsistencies
* ams.zookeeper.principal
-- Is: zookeeper/_HOST@${realm}
-- Should be: amszk@_HOST${realm}
* ams.zookeeper.keytab 
-- Is: ${keytab_dir}/zk.service.ams.keytab
-- Should be: ${keytab_dir}/ams-zk.service.keytab

**Solution**
Update the Ambari Metrics Kerberos Descriptor file with the new default values. 


#Missing CSV entries
* ams.collector.ketab
* ams-hbase.regionserver.keytab

**Solution**
Fixed logic that weeds out duplicate principal names to weed out a unique keys 
consisting of the principal name and keytab file. By using only the princpal 
name, entries were being left out that happen to have the same prinaical name 
but needed to be in different keytab files.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 6b970c6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
 03c3f93 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 54170a6 

Diff: https://reviews.apache.org/r/34127/diff/


Testing
-------

Manually tested in cluster

**Jenkins test results: PENDING**


Thanks,

Robert Levas

Reply via email to