-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33663/
-----------------------------------------------------------
(Updated May 15, 2015, 11:23 a.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav
Papirkovskyy, and Nate Cole.
Changes
-------
Uploaded test with ignored unit tests to resolve a blocker
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.812s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.483s]
[INFO] Ambari Server ..................................... SUCCESS [49:36.656s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49:41.716s
[INFO] Finished at: Fri May 15 14:00:30 EEST 2015
[INFO] Final Memory: 34M/300M
[INFO] ------------------------------------------------------------------------
Bugs: AMBARI-10818
https://issues.apache.org/jira/browse/AMBARI-10818
Repository: ambari
Description
-------
Problem here is that DistributeRepositoriesActionListener is executed in a
separate thread. So we have to use UnitOfWork just like at
org.apache.ambari.server.actionmanager.ActionScheduler#doWork , otherwise
EntityManager cache is not updated on DB updates. I mean that RepositoryVersion
state at DB is INSTALLING, and API shows INSTALLING, but RepositoryVersion
state in DistributeRepositoriesActionListener is still INSTALLED, and cluster
state transition is not performed.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
d838d25
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
85973b1
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java
9a2be15
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
d3c4bd4
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java
bd5defb
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
119737c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/MemberDAO.java
e831db2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PermissionDAO.java
939c32b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalDAO.java
7ac4f05
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrincipalTypeDAO.java
046345a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java
4fda7bc
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
d55a00f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
7e190a3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StackDAO.java
6405068
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java
c2b551b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java
031601a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java
a9b913f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java
2fcb087
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewDAO.java
bbbab63
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
91a2e72
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java
2e0f238
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
92866d7
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java
e6a95ae
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
e03c2f5
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
f3694c9
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java
c289bcc
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
63c5440
Diff: https://reviews.apache.org/r/33663/diff/
Testing
-------
Same tests are failing on trunk
Tests in error:
test220Cardinality(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
test220AutoDeploy(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
test220Dependencies(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
testCommonOozieServiceDescriptor(org.apache.ambari.server.stack.KerberosDescriptorTest):
/media/plextor/review_ambari/ambari-server/target/classes/common-services/OOZIE/5.0.0.2.3/kerberos.json
is not a readable file
Tests run: 2951, Failures: 0, Errors: 4, Skipped: 17
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.900s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.570s]
[INFO] Ambari Server ..................................... FAILURE [43:59.418s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44:04.603s
[INFO] Finished at: Wed May 06 20:25:17 EEST 2015
[INFO] Final Memory: 32M/268M
[INFO] ----------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
