----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34333/#review84083 -----------------------------------------------------------
Ship it! Nice turnaround on this to get the tests enabled. One thing that's bothering me ... why do only some tests have this issue? Within the same class, some tests fail while others work. The same @Before and @After is running for them, yet only some methods fail. - Jonathan Hurley On May 17, 2015, 2:12 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34333/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 2:12 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, and Nate Cole. > > > Bugs: AMBARI-11200 > https://issues.apache.org/jira/browse/AMBARI-11200 > > > Repository: ambari > > > Description > ------- > > Fix unit tests that were disabled when committing blocker AMBARI-10818 > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 7f5cbfb > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java > 547edf2 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java > 4138774 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java > c774474 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 1bc6436 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > 31b707a > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java > aa6f1df > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 677ee1a > > Diff: https://reviews.apache.org/r/34333/diff/ > > > Testing > ------- > > Running full mvn test (in progress) > > > Thanks, > > Dmitro Lisnichenko > >
