-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34292/
-----------------------------------------------------------
(Updated May 17, 2015, 10:28 p.m.)
Review request for Ambari, Alejandro Fernandez, Billie Rinaldi, Dmytro Sen, and
Sumit Mohanty.
Changes
-------
Removed timeshifting client side timestamps to adding a configurable timeshift
to the server time.
This allows for some room to accoomodate time slices without any falling out.
Bugs: AMBARI-11184
https://issues.apache.org/jira/browse/AMBARI-11184
Repository: ambari
Description
-------
http://104.196.88.124:8080/api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/ClusterMetrics/NumActiveNMs._sum[1431372267,1431375867,15]&_=1431375867
Above is an API to return series data for number of active nodemanagers in the
asked time interval. Although the cluster has only 1 nodemanager installed, a
specific datapoint had 2 as a value which is incorrect.
*NOTE: Since there is only 1 nodemanager installed, the valid set of values at
any time is {0,1}.*
http://c6401.ambari.apache.org:8080/api/v1/clusters/test_widg/services/ACCUMULO/components/ACCUMULO_TSERVER?fields=metrics/tserver/general/entries._max
for _max, _min, _sum, and _avg are returning the same value. The
metrics_aggregate table in phoenix looks like it has correct values for the
sum, max, and min, but I appear to only be getting back the value from a single
host component through the rest API.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
b890171
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
0595c20
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorMinute.java
293608e
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java
398f4c3
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
6cfaa2e
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITClusterAggregator.java
fb3bc30
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
fc52e5a
Diff: https://reviews.apache.org/r/34292/diff/
Testing
-------
All unit tests pass. Manually verified.
Thanks,
Sid Wagle
