-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34367/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-11224
https://issues.apache.org/jira/browse/AMBARI-11224
Repository: ambari
Description
-------
Don't enforce 'required' validation for cluster config parameters since the
value will be obtained through cluster association, not user input.
Fails to create a view unless <default-value> is specified. A view instance
should be create'able with cluster association even if it doesn't have a
default value as long as it has cluster-config.
Error is "No property values exist for the required parameter..."
<parameter>
<name>cluster.url</name>
<description>Enter Ambari Server Cluster URL</description>
<placeholder>http://ambari.server:8080/api/v1/clusters/MyCluster</placeholder>
<cluster-config>yarn-env/yarn_user</cluster-config>
<required>true</required>
</parameter>
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
6855b56
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
036fa03
Diff: https://reviews.apache.org/r/34367/diff/
Testing
-------
Manual test.
New unit test added.
mvn clean test
Thanks,
Tom Beerbower