----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34421/#review84378 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/34421/#comment135599> Nit: no need for a builder anymore, just String.format(...) for the detail. - Nate Cole On May 19, 2015, 1:49 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34421/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 1:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-11245 > https://issues.apache.org/jira/browse/AMBARI-11245 > > > Repository: ambari > > > Description > ------- > > The ConfigureTask should be able to support multiple sets as part of its > payload. Example: > > {code} > <task xsi:type="configure"> > <type>yarn-site</type> > <set key="yarn.timeline-service.recovery.enabled" value="true"/> > <set key="yarn.timeline-service.recovery.foo" value="foobar"/> > <set key="yarn.timeline-service.recovery.bar" value="baz"/> > </task> > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 81a15ec > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > 03b9fa3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 5b47ee6 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > e954af2 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > 6ca677a > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > c51cf2d > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 0e5e53c > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml > bbaa178 > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test.xml > 08e69d7 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml > 4ad019c > > Diff: https://reviews.apache.org/r/34421/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
