----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34448/#review84425 -----------------------------------------------------------
Ship it! Ship It! - Xi Wang On May 19, 2015, 5:02 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34448/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 5:02 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-11255 > https://issues.apache.org/jira/browse/AMBARI-11255 > > > Repository: ambari > > > Description > ------- > > Following issues related to create widget wizard are being addressed by this > patch: > STR: > # Launch create widget wizard > # Refresh browser on any of the page and complete widget creation > *Expected Result:* widget gets created and becomes part of the active widget > layout > *Actual Result:* widget gets created but does not becomes part of the active > widget layout > > Apart from this, patch also addresses following issues: > > # Even without refresh on the create widget wizard, widget gets created and > becomes part of the active layout but a browser refresh or renavigation > needs to happen on summary page to see it > # Created widget has additional malformed field 'data' for metrics attribute > of the widget > # While selecting aggregator function "avg", it does not get suffixed at the > end of the metric name. > > > Diffs > ----- > > ambari-web/app/controllers/main/service/info/summary.js c56a922 > ambari-web/app/controllers/main/service/widgets/create/step3_controller.js > 24b32f8 > ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js > 4c1dd06 > ambari-web/app/mixins/common/widgets/widget_section.js 20863c3 > ambari-web/app/routes/add_widget.js 2631b16 > ambari-web/app/routes/create_widget.js PRE-CREATION > ambari-web/app/routes/main.js 45a9102 > ambari-web/app/views/main/service/widgets/create/expression_view.js a232d89 > > Diff: https://reviews.apache.org/r/34448/diff/ > > > Testing > ------- > > tested e2e and verified that all existing unit tests passes > > > Thanks, > > Jaimin Jetly > >
