----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34464/#review84492 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On May 20, 2015, 11:08 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34464/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 11:08 a.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-11263 > https://issues.apache.org/jira/browse/AMBARI-11263 > > > Repository: ambari > > > Description > ------- > > Since we create users and groups in before-ANY hook, it gets executed a lot. > > The way to optimize it is not to call expensive edit user command, until we > are sure the user is different than we need. > > > Diffs > ----- > > ambari-agent/src/test/python/resource_management/TestDirectoryResource.py > 7667a2d > ambari-agent/src/test/python/resource_management/TestExecuteResource.py > d92f905 > ambari-agent/src/test/python/resource_management/TestFileResource.py > 4caa69c > ambari-agent/src/test/python/resource_management/TestGroupResource.py > d0ca261 > ambari-agent/src/test/python/resource_management/TestUserResource.py > 07b4e1e > > ambari-common/src/main/python/resource_management/core/providers/accounts.py > d14ae34 > ambari-common/src/main/python/resource_management/core/providers/system.py > 07155f5 > ambari-common/src/main/python/resource_management/core/sudo.py e7bb08a > ambari-common/src/main/python/resource_management/core/utils.py cc8b404 > > Diff: https://reviews.apache.org/r/34464/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
