----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34468/#review84560 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On May 20, 2015, 2:06 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34468/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 2:06 p.m.) > > > Review request for Ambari, Robert Levas, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-11266 > https://issues.apache.org/jira/browse/AMBARI-11266 > > > Repository: ambari > > > Description > ------- > > Recently, during 2.1 development, API additions were made that allow a host > count and host predicate to be specified for blueprint provision and scaling > requests. > > The additions are documented in the Apache Jira: > https://issues.apache.org/jira/browse/AMBARI-10750 > > After some consideration and discussion, it has become clear that the > host_count and host_predicate fields need to move up one level form their > current location under hosts. Only explicitly specified hosts will be > contained within "hosts". > > For example: > { > "blueprint" : "bp1", > "host_groups" :[ > { > "name" : "master", > "hosts" : [ > { > "fqdn" : "john2.novalocal" > } > ] > }, > { > "name" : "slave", > "host_count" : "5", > "host_predicate" : "Hosts/cpu_count>1" > } > ] > } > > * Note to reviewers: All changes outside of ProvisionClusterRequest are due > to a method rename. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExportBlueprintRequest.java > 1e71094 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java > 1a4520e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java > b9a4173 > > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java > 88c791b > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java > 4101d67 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyRequest.java > c4dcfb0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java > 82dd705 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java > 91b6c6f > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java > eac269b > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > 8d72d79 > > Diff: https://reviews.apache.org/r/34468/diff/ > > > Testing > ------- > > Functional Testing: > - Created multiple clusters > - Tested invalid request handling > > Unit Testing: > - Updated existing tests > - All tests pass > > Results : > > Tests run: 3000, Failures: 0, Errors: 0, Skipped: 21 > ... > Total run:741 > Total errors:0 > Total failures:0 > > > Thanks, > > John Speidel > >
