----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34504/#review84607 -----------------------------------------------------------
Ship it! Ship It! - Xi Wang On May 20, 2015, 3:39 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34504/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 3:39 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-11287 > https://issues.apache.org/jira/browse/AMBARI-11287 > > > Repository: ambari > > > Description > ------- > > we are using async call to load all metrics while landing on "Metrics & > Expression" page ([code link | > https://github.com/apache/ambari/blob/trunk/ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js#L122]). > Thus "Get all metrics" API call does not delay loading of the page itself. > But on a slow network if a user lands on the page and subsequently clicks on > "Add metrics" button, then nothing appears until the "Get all metrics" API > call is completed. > > > Diffs > ----- > > ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js > 7dd6cc3 > ambari-web/app/controllers/main/service/widgets/edit_controller.js 1744974 > ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs > c88e6f8 > > Diff: https://reviews.apache.org/r/34504/diff/ > > > Testing > ------- > > tested on a live cluster. > verified that all unit tests passes. > > > Thanks, > > Jaimin Jetly > >
