----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34513/#review84714 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml <https://reviews.apache.org/r/34513/#comment136051> I was following this pattern for Hive when I realized something. Are these keys renames? If so, shouldn't we just use the "move" action to rename it in the new config? That would save us from having to do the copy/delete - Jonathan Hurley On May 21, 2015, 11:12 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34513/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:12 a.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-11289 > https://issues.apache.org/jira/browse/AMBARI-11289 > > > Repository: ambari > > > Description > ------- > > * Added configuration changes for ranger plugins > * Added masked attribute for sensitive config changes being written to task > stdout. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > c5f33c4 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 99d6058 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 7505a07 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > c2ea948 > > Diff: https://reviews.apache.org/r/34513/diff/ > > > Testing > ------- > > Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:51.152s > [INFO] Finished at: Wed May 20 20:48:28 EDT 2015 > [INFO] Final Memory: 30M/1338M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
