----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34578/#review84844 -----------------------------------------------------------
Ship it! Ship It! - Xi Wang On May 21, 2015, 5:37 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34578/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 5:37 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-11118 > https://issues.apache.org/jira/browse/AMBARI-11118 > > > Repository: ambari > > > Description > ------- > > This happened because select tag which was a childView of the view from whose > didInsertelement method jquery choosen plugin was being activated. This > resulted into trying to activate a Jquery plugin when the select tag was not > availaible in the DOM > > > Diffs > ----- > > ambari-web/app/templates/common/chosen_plugin.hbs PRE-CREATION > ambari-web/app/templates/main/service/widgets/create/step2_add_metric.hbs > 314f5b1 > ambari-web/app/views.js a684f41 > ambari-web/app/views/common/chosen_plugin.js PRE-CREATION > ambari-web/app/views/main/service/widgets/create/expression_view.js 80f6446 > > Diff: https://reviews.apache.org/r/34578/diff/ > > > Testing > ------- > > tested on a live cluster multiple time and was not able to reproduce the > issue with the patch > created a widget with the patch > veridied that all existing unit tests passes with the patch > > > Thanks, > > Jaimin Jetly > >
