-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34594/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk, Gautam Borad, Mehul Parikh, and
Velmurugan Periasamy.
Bugs: AMBARI-11337
https://issues.apache.org/jira/browse/AMBARI-11337
Repository: ambari
Description
-------
Following issues needs to be resolved as part of this ticket:
On Select services page after selecting ranger and proceeding: Ambari web
should not have specific references to HDP or any other stack name. Remove
reference to HDP 2.2. Instead refer to Ranger 0.4.0 or show that specific
requirement only if Ranger 0.4.0 is being installed (again logic depending on
Ranger service version rather than HDP version).
While landing on Customize services page JDBC driver warning is not shown until
the database option is changed. Expected behavior is to show the warning when
user lands on the page irrespective of the DB option value.
On switching to Ranger service on customize services page, undo buttons are
shown by default for Driver class name for a JDBC Ranger database and Ranger DB
host . Clicking on undo button for Driver class name for a JDBC Ranger database
makes it blank. Expected behavior is that no undo sign should be present for
this property. It's behavior should be similar to JDBC connect string for a
Ranger database.
Default value for Ranger DB host should be blank in stack meaning user should
be enforced to enter a value on customize service page.
User friendly name should be used for DB FLAVOR and it's options
DB FLAVOR -> DB Flavor
MYSQL -> Existing MySQL Database
ORACLE -> Existing Oracle Database
POSTGRES -> Existing PostgreSQL Database
MSSQL -> Existing Microsoft SQL Database
Show SQL Command Invoker on user interface only if it makes sense and user is
likely to tweak it. Otherwise depending upon the ranger JDBC driver class, SQL
command invoker can be derived on agent script and no need to expose it in
ambari API and UI.
The order of properties shown in DB settings section needs to corrected. In my
opinion "Ranger Server host, DB Flavor, Ranger DB host, Ranger DB username,
Ranger DB password, Ranger DB root user, Ranger DB root password, Ranger DB
name, Driver class name for a JDBC Ranger database, JDBC connect string for a
Ranger database, Test Connection, Ranger Audit DB name, Ranger Audit DB
username, Ranger Audit DB password.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml
aefb200
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/admin-properties.xml
52ce1bf
ambari-web/app/data/HDP2.2/site_properties.js 537fa84
ambari-web/app/data/HDP2.3/site_properties.js 5a351b5
ambari-web/app/messages.js 15e275a
ambari-web/app/views/common/controls_view.js 995ace7
Diff: https://reviews.apache.org/r/34594/diff/
Testing
-------
6150 tests complete (11 seconds)
86 tests pending
Thanks,
Aleksandr Kovalenko
