----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34606/#review85002 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/34606/#comment136467> We dont need this refactoring. No nice to haves at this point. Remove this. Also any change to common code requires testing on Linux environment. Can you make sure that the changes to resource_management, common-services dont break on Linux. ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py <https://reviews.apache.org/r/34606/#comment136471> We dont need to add any new components or services. Remove this. ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py <https://reviews.apache.org/r/34606/#comment136472> We dont need to add any new components or services. Remove this. ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py <https://reviews.apache.org/r/34606/#comment136473> We dont need to add any new components or services. Remove this. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py <https://reviews.apache.org/r/34606/#comment136474> We dont need to add any new components or services. Remove this. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py <https://reviews.apache.org/r/34606/#comment136475> We dont need to add any new components or services. Remove this. ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/repo_definition.py <https://reviews.apache.org/r/34606/#comment136463> We dont need this refactoring. No nice to haves at this point. Remove this. ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/repo_definition.py <https://reviews.apache.org/r/34606/#comment136464> We dont need this refactoring. No nice to haves at this point. Remove this. ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py <https://reviews.apache.org/r/34606/#comment136478> Isnt this validateHiveConfigurations() so why do we need ranger-hdfs-plugin-enabled. Also is this logic same as in HDP and should be fixed for HDP as well? It would be best to fix this in a separate JIRA and work with Srimanth on it. ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml <https://reviews.apache.org/r/34606/#comment136483> This file has a lot of duplicated properties from /Users/jluniya/release/2.0.0/ambari/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml. This is unnecessary as config files are merged at per property level. We really need to avoid duplication and add only new/changed properties based on the stack hierarchy. The list should be a lot shorter. Same applies for all other service configs. ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/repo_definition.py <https://reviews.apache.org/r/34606/#comment136479> Remove refactored code. - Jayush Luniya On May 22, 2015, 9:20 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34606/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 9:20 p.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jayush Luniya, > and Mahadev Konar. > > > Bugs: AMBARI-11348 > https://issues.apache.org/jira/browse/AMBARI-11348 > > > Repository: ambari > > > Description > ------- > > +Added HDPWIN 2.3 stack definition > +Created a modular repository model, with support for multiple file downloads > and componentized installation > +Fixed startup issues for HBase, Hive, Oozie, Storm and YARN > +Fixed build break in ambari-agent > > > Diffs > ----- > > ambari-agent/pom.xml 1cf3b71879714397cc57b4976dd7d857faf8daac > ambari-common/src/main/python/ambari_commons/os_utils.py > 9126a5b34a6fc85fbe12869119295b97ec20d738 > > ambari-common/src/main/python/resource_management/core/providers/windows/system.py > a410e9c0790757c221700e5556c33edaa376bdc8 > > ambari-common/src/main/python/resource_management/libraries/functions/install_hdp_msi.py > 12ccc51ddbbfdb36f2b067c16f9fa6b0eaf88e77 > > ambari-common/src/main/python/resource_management/libraries/functions/reload_windows_env.py > eaa25827d045c524b89423307a1cc5a76ffdb03c > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 2b1c7632eaca4cba2bf17f4f3a7eb8464c4a0f39 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py > 139e2bb85ffe29bc17ecfe9141215add68c675b2 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py > 678cb02332de1a386f8c599160ed114421a66c10 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py > c1325033ae15734f92e000cfd943d7e917c71759 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_queryserver.py > c12231a945f058655adc86649569ccf65a2eb301 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py > d679314d4522f05d938aca7c35900bf89c4ddad9 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py > 084ee06b5eda5ce3bb706f57c3502ae036ef9e55 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py > d599b8cc43a83955b09886cfb607538f811839e8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > c3ee304a20f25959a209fb0acdf1af6206f8464a > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py > 388fa59628410da457a0c37cfb8992711747292d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py > 3e6ec9e0f61b890694a0d424f9e285b940ae29b8 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py > 36dd07ff6ad6ade6a3a4aa4b9d00726169bab41c > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > aef90ee7c9122743ec9a4ef65d1de62e9ccf5739 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > d52b787ad0295bff23f6cf95622ef9272553e61c > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py > c1271155b6294fc0253b7043b0b00fdba758f1a8 > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_linux.py > 98a408c939fca1c637b4c6ae44e8e892e04886bb > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params_windows.py > 932c5a44a3557ac3f5e8042d2e29e607d7e6cb7a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py > d98246cc6a7ee6bef0525eeefe5cb28b16740f6d > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py > 4484501e2ca06bc486febc216fde696ece1064ef > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py > 6e99e8b517f122b1616c3b9ac25acec1072221b6 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py > b4c5b6ed56ebf73847ff1ac98f98429ff275d97e > ambari-server/src/main/resources/stacks/HDPWIN/2.1/metainfo.xml > ca458226042b9a6ede74fd3d7ba987f009c07023 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-env.xml > 3b421b9bd16f6eb1fb457e8515235752c759ac1f > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/repo_definition.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > c2125630164af1a493c28561e278d3ac830d2c11 > ambari-server/src/main/resources/stacks/HDPWIN/2.2/metainfo.xml > 36f01e0c0d4a188b4c0037aad4df9af41d8fa0f1 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/webhcat-site.xml > 0454c1cc6666cbb5711d1e4b949ea97865073678 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/repo_definition.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > 98ec4d5d9befae88d0533eb442c2aa7ef7b296a8 > ambari-server/src/main/resources/stacks/HDPWIN/2.3/metainfo.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDPWIN/2.3/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/FALCON/configuration/falcon-startup.properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/FALCON/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/FLUME/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HDFS/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hiveserver2-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/webhcat-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/KNOX/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/PIG/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/SLIDER/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/SQOOP/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/YARN/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/ZOOKEEPER/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/repo_definition.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/stack_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/34606/diff/ > > > Testing > ------- > > local VM cluster deployment > > > Thanks, > > Florian Barca > >
