> On May 22, 2015, 7:24 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py, lines > > 102-103 > > <https://reviews.apache.org/r/34610/diff/1/?file=969910#file969910line102> > > > > I don't think this would fix the issue. It was reported that log > > statements were getting repeated expontially. This just changes the logger > > to ERROR from INFO. > > Andrew Onischuk wrote: > yep I agree with that, just a workaround. (which worked btw) We can as > well set disabled = True. For this logger to completely remove alert logs > from out. > But if you have better solution, meaning which really fixes the reason > why it grows so much, it probably be better to commit that instead.
No, it's bizzare to say the least. I think we want this in temporarily to unblock some tests that are failing due to disk space. Let's +1 this and create a new Jira to track the actual issue with duplicate log entries. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34610/#review85021 ----------------------------------------------------------- On May 22, 2015, 4:01 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34610/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 4:01 p.m.) > > > Review request for Ambari and Jonathan Hurley. > > > Bugs: AMBARI-11349 > https://issues.apache.org/jira/browse/AMBARI-11349 > > > Repository: ambari > > > Description > ------- > > See attached files. This came from a devdeploy test where some service check > was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not > the reason but was the largest contributor. > > Can you check if we can avoid logging to the out file unless there was an > error due to which this is expected? > > If out file does not roll this could be an issue in the long run. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py b8b4daf > > Diff: https://reviews.apache.org/r/34610/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
