----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34623/#review85046 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On May 23, 2015, 1:23 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34623/ > ----------------------------------------------------------- > > (Updated May 23, 2015, 1:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-11358 > https://issues.apache.org/jira/browse/AMBARI-11358 > > > Repository: ambari > > > Description > ------- > > The following three config properties should be removed if the values are the > HDP-2.2 default. > > * yarn.scheduler.capacity.root.accessible-node-labels.default.capacity > ** Remove if value is "-1" > * yarn.scheduler.capacity.root.accessible-node-labels.default.maximum-capacity > ** Remove if value is "-1" > * yarn.scheduler.capacity.root.default-node-label-expression > ** Remove if value is " " (space) > > There is currently no logic in place that says remove a property if the > property meets a condition. That would require work. Some options: > > - We have the ability to set a property if a property meets a condition. For > example, we can set > {{yarn.scheduler.capacity.root.accessible-node-labels.default.capacity}} to > {{""}} or {{10}} if it is currently {{-1}} > - We can just set it regardless of any condition to any value > - We can just remove it outright > - We can write a pre-req check and have the user change it. > > The best balance of effort/reward is option #1 - conditionally set the > properties. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 6d50008 > > Diff: https://reviews.apache.org/r/34623/diff/ > > > Testing > ------- > > Upgraded YARN > > > Thanks, > > Jonathan Hurley > >
