> On May 26, 2015, 3:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java, > > line 260 > > <https://reviews.apache.org/r/34657/diff/1/?file=971506#file971506line260> > > > > Comma-separated classpath? Does that work on all OSes?
Thanks for the review. I used a comma separated list because that is accepted by Jetty WebAppContext.setExtraClasspath() which is what gets called in the ViewClassLoader. Doesn't matter what the OS is. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34657/#review85177 ----------------------------------------------------------- On May 25, 2015, 8:43 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34657/ > ----------------------------------------------------------- > > (Updated May 25, 2015, 8:43 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-11208 > https://issues.apache.org/jira/browse/AMBARI-11208 > > > Repository: ambari > > > Description > ------- > > Each view should expose a way to set extra classpath info for a view. > > <view> > <name>HELLO_WORLD</name> > <label>The Hello World View!</label> > <version>1.0.0</version> > <classpath> > <path>/usr/lib/ambari-server/foo.jar</path> > <path>/home/hdfs/</path> > </classpath> > <instance> > <name>INSTANCE_1</name> > </instance> > </view> > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java > b7cb594 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java > 43efc7d > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java > 6164bb7 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java > 8e22c49 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a0ee6b3 > > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java > beb8bde > ambari-views/src/main/resources/view.xsd 37737c1 > > Diff: https://reviews.apache.org/r/34657/diff/ > > > Testing > ------- > > Manual tested. > > Added new unit tests. > > mvn clean test > > All tests pass. > > > Thanks, > > Tom Beerbower > >
