----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34672/#review85248 -----------------------------------------------------------
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java <https://reviews.apache.org/r/34672/#comment136773> This seems a little funny since the cluster should either be _local_ or _remote_, maybe an `if/else if /else` is in order?. What happens if both checks come up *false*? Should an exception be thrown? See `#readFromAmbari`. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java <https://reviews.apache.org/r/34672/#comment136774> This seems a little funny since the cluster should either be _local_ or _remote_, maybe an `if/else if /else` is in order?. What happens if both checks come up *false*? Should an exception be thrown? See `#readFromAmbari`. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java <https://reviews.apache.org/r/34672/#comment136775> `BUG-37458` should be changed to `AMBARI-11310` contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java <https://reviews.apache.org/r/34672/#comment136788> Remove this comment? contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java <https://reviews.apache.org/r/34672/#comment136789> Surround this with `{` and `}` o help with readability and keep with Ambari code standards. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java <https://reviews.apache.org/r/34672/#comment136790> Surround this with `{` and `}` o help with readability and keep with Ambari code standards. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java <https://reviews.apache.org/r/34672/#comment136791> Surround this with `{` and `}` o help with readability and keep with Ambari code standards. contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java <https://reviews.apache.org/r/34672/#comment136794> Extra blank line should be removed contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java <https://reviews.apache.org/r/34672/#comment136795> Maybe limit this to prevent infinite loop... `triesCount < 1000`? contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java <https://reviews.apache.org/r/34672/#comment136797> Surround this with `{` and `}` o help with readability and keep with Ambari code standards. There is a lack of JavaDoc comments. I beleive this patch should have some better JavaDocs. - Robert Levas On May 26, 2015, 2:28 p.m., Erik Bergenholtz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34672/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 2:28 p.m.) > > > Review request for Ambari, aantonioxrr aantonioxrr, Robert Levas, and Tom > Beerbower. > > > Bugs: AMBARI-11391 > https://issues.apache.org/jira/browse/AMBARI-11391 > > > Repository: ambari > > > Description > ------- > > This patch changes the version of the files view to 0.2.0 AND adds support > for NameNode HA (nameservice). > > > Diffs > ----- > > contrib/views/files/pom.xml 5350c48 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 1685450 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java > ded3684 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java > b521085 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java > c66bd8f > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java > 695ca38 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/PropertyValidator.java > abc4f2b > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java > 051bdfb > contrib/views/files/src/main/resources/view.xml dbd0643 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > d481323 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/HdfsServiceTest.java > cc02a3f > contrib/views/pom.xml 6eb6aeb > contrib/views/utils/pom.xml PRE-CREATION > contrib/views/utils/readme.md PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApiException.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/RemoteCluster.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApiException.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java > PRE-CREATION > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java > PRE-CREATION > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java > PRE-CREATION > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilderTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34672/diff/ > > > Testing > ------- > > Local deploy and unit tests: > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.view.utils.ambari.RemoteClusterTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.321 sec > Running org.apache.ambari.view.utils.ambari.URLStreamProviderBasicAuthTest > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.635 sec > Running org.apache.ambari.view.utils.hdfs.ConfigurationBuilderTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.26 sec > > Results : > > Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 > > > Files View: > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.ambari.view.filebrowser.FilebrowserTest > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.846 sec > > Results : > > Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Erik Bergenholtz > >
