----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34680/#review85262 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On May 26, 2015, 8:56 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34680/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:56 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-11399 > https://issues.apache.org/jira/browse/AMBARI-11399 > > > Repository: ambari > > > Description > ------- > > When upgrading between HDP 2.2 and HDP 2.3, the merged configurations are not > taking an override that exists in HDP 2.3 if the property was originally > defined in HDP 2.2. For example: > > HDP 2.2: foo=bar > HDP 2.3: foo=baz > > If the current value on the installed cluster is "bar" then then it was not > customized and the new value of "baz" should be used. Only if the current > stack value doesn't equal "bar" should the original value be preserved. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > a644d78 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 4e2fbcd > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 12e6efe > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 7fb8f66 > > Diff: https://reviews.apache.org/r/34680/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
