----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34648/#review85348 -----------------------------------------------------------
Ship it! I don't see any issues that really stand out in this 2nd patch, but it also seems like no functionality changed either. - Jonathan Hurley On May 26, 2015, 8:57 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34648/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:57 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > and Tom Beerbower. > > > Bugs: AMBARI-11367 > https://issues.apache.org/jira/browse/AMBARI-11367 > > > Repository: ambari > > > Description > ------- > > Knox Upgrade failed because the /usr/hdp/current/knox-server/conf/topologies > directory doesn't exist and needs to be created. > Further, the admin.xml file exposes the Knox API, and the file needs to be > copied from the older config folder to the new one after calling conf-select. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Controller.py 30aedd0 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py > 6caec01 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > fd7b451 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > c4a5ad6 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py > 9976cb2 > ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py bab4ed1 > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/34648/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Total run:742 > Total errors:0 > Total failures:0 > OK > > Verified that multiple Knox gateways passed during RU from HDP 2.3.0.0 to > 2.3.0.0+ (an older version). > > > Thanks, > > Alejandro Fernandez > >
