> On May 27, 2015, 2:53 p.m., John Speidel wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java, > > line 169 > > <https://reviews.apache.org/r/34706/diff/1/?file=972601#file972601line169> > > > > The intended behavior here is to only add the service components which > > are represented in the blueprint used for cluster deployment. > > > > If the UI wants to add additional components which aren't represented > > in the original blueprint, the the UI should create those components which > > don't yet exist for the cluster. > > > > In my opinion, it doesn't make any sense to add components to a cluster > > if they aren't part of the cluster.
+1 for John's comments. I don't think we should be adding all components under a service, just because they happen to be defined in a stack. If the PHOENIX_QUERY_SERVER is a component that should always be added in certain types of deployments, then it makes more sense to model this as a dependency. Adding all the components under the stack will produce un-intended consequences for the cluster deployer. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34706/#review85367 ----------------------------------------------------------- On May 27, 2015, 1:20 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34706/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 1:20 p.m.) > > > Review request for Ambari and John Speidel. > > > Bugs: AMBARI-11424 > https://issues.apache.org/jira/browse/AMBARI-11424 > > > Repository: ambari > > > Description > ------- > > **STR** > Install cluster **without** Phoenix Query Server > Launch add host wizard, select Phoenix Query Server as component for adding > > **Result** > During deploying task exception occurred. See it on screenshot attached. > > > > > org.apache.ambari.server.controller.spi.SystemException: An internal > system exception occurred: ServiceComponent not found, clusterName=cl1, > serviceName=HBASE, serviceComponentName=PHOENIX_QUERY_SERVER > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0de4b00 > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > 7dcb7be > > Diff: https://reviews.apache.org/r/34706/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
