----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34712/#review85377 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Травень 27, 2015, 3:09 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34712/ > ----------------------------------------------------------- > > (Updated Травень 27, 2015, 3:09 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-11349 > https://issues.apache.org/jira/browse/AMBARI-11349 > > > Repository: ambari > > > Description > ------- > > See attached files. This came from a devdeploy test where some service check > was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not > the reason but was the largest contributor. > > Can you check if we can avoid logging to the out file unless there was an > error due to which this is expected? > > If out file does not roll this could be an issue in the long run. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f > > Diff: https://reviews.apache.org/r/34712/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
