-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34791/
-----------------------------------------------------------

(Updated May 29, 2015, 12:34 a.m.)


Review request for Ambari and Robert Levas.


Bugs: AMBARI-11516
    https://issues.apache.org/jira/browse/AMBARI-11516


Repository: ambari


Description
-------

Make an enhancement to view framework to expose a connection provider interface 
and make it available through the view context. 

This is being requested because the existing URLStreamProvider interface can 
only return a stream and does not provide any http error code or response body 
on failures.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 
9a4aae2 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
 bb3b8aa 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java
 b470da2 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java
 e606820 
  ambari-views/src/main/java/org/apache/ambari/view/URLConnectionProvider.java 
PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 2522486 

Diff: https://reviews.apache.org/r/34791/diff/


Testing (updated)
-------

New unit tests added.

mvn clean test

all tests pass

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52:12 min
[INFO] Finished at: 2015-05-28T19:56:18-04:00
[INFO] Final Memory: 56M/1220M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower

Reply via email to