-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34802/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-11528
https://issues.apache.org/jira/browse/AMBARI-11528
Repository: ambari
Description
-------
In 5-min snapshot processing of onAlertEvent method took ~94 seconds producing
46k commits and almost same amount of db requests (~equally split between
alert_history and alert_definition tables)
this can be related to large amount to alerts, but it should be addressed as we
can have even more alerts on larger clusters, and it can be caused by a single
thread only for all listeners, so there's possible bottleneck here.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
34ad7eb
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
849c19a
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
d3ed1b4
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/AlertEventPublisher.java
006837a
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDispatchDAO.java
22fb76f
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java
c2bca06
ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java
6edf7d9
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
afffde9
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java
37a6db3
ambari-server/src/test/java/org/apache/ambari/server/alerts/AgentHeartbeatAlertRunnableTest.java
d61db07
ambari-server/src/test/java/org/apache/ambari/server/alerts/StaleAlertRunnableTest.java
94a0bc2
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertResourceProviderTest.java
5459a8c
Diff: https://reviews.apache.org/r/34802/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen