----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34848/#review85875 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On May 30, 2015, 6:16 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34848/ > ----------------------------------------------------------- > > (Updated May 30, 2015, 6:16 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Tom Beerbower. > > > Bugs: AMBARI-11559 > https://issues.apache.org/jira/browse/AMBARI-11559 > > > Repository: ambari > > > Description > ------- > > AMBARI-10249 will create a permanent paper trail of alert state change events > (essentially alert history) that is separate and not coupled to the database > audit of alert events. > > > Currently, removal of a service or a component does not remove the > definitions associated with the component. It merely clips the tip of the > history so that no alerts are present anymore. Based on feedback of Ambari > 2.0.0, this Jira is to track the need to automatically delete alert > definitions when a service or component is removed. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java > fd7035d > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > b4ec0a8 > > Diff: https://reviews.apache.org/r/34848/diff/ > > > Testing > ------- > > Removed HBase and verified that all definitions, alerts, groups, and notices > were removed as well. > > new unit test added > mvn clean test > > > Thanks, > > Jonathan Hurley > >
